Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change a single hardcoded FTDI USB Product ID to a list. #126

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Change a single hardcoded FTDI USB Product ID to a list. #126

merged 1 commit into from
Sep 10, 2018

Conversation

mlasevich
Copy link
Contributor

Fix for #125 - Ability to support FT-X based Adapters like SparkFun's XBee Explorer.

I listed out other FTDI chips, but as I am not sure if they are completely compatible, I left them commented out.

@mlasevich
Copy link
Contributor Author

Any issues with this? Would like to be able to use the official library as soon as it is possible. Thanks.

@rubenmoral
Copy link
Member

Sorry @mlasevich, we had forgotten this... Here you have our approval, you can go ahead and merge it.

@mlasevich
Copy link
Contributor Author

mlasevich commented Sep 10, 2018 •
edited
Loading

Appreciate the approval, but I don't think I have the rights to merge it :-)

@rubenmoral rubenmoral merged commit 6d46906 into digidotcom:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenmoral rubenmoral rubenmoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlasevich @rubenmoral